Metadata Improvements #106
Conversation
for more information, see https://pre-commit.ci
| method = "nearest" | ||
| da = da.sel({dim: value}, method=method) | ||
| if value is None: | ||
| da = da.isel({dim: 0}) |
There was a problem hiding this comment.
I am guessing this is necessary because otherwise you get an error if you dont specify?
There was a problem hiding this comment.
well the actual issue was happening at L177 where it would try to get a query parameter that could sometimes be missing (as it seems like we allow any extent to be missing from the query), so that's why I added the if k in query_params else None there. And since I would imagine it wouldn't work to try and get the closest value to None, I added that condition to just get the first value.
There was a problem hiding this comment.
oooook got it. Ok so i think L177 might work as this instead? This would filter instead of having to set them as None
{ k: query_params[k] for k in available_selectors if k in query_params}
There was a problem hiding this comment.
That would work except that we would need to use ds.gridded.additional_coords(ds[self.parameter]) to iterate through the extra dimensions rather than self.dim_selectors, which I'm not sure about. We would always need to filter the data by those dims in order for to have the correct number of dims for GetMap right?
There was a problem hiding this comment.
Yeah its true. Its a decision about whether a tile should work by default vs if it should fail if the user didnt pass in dimensions.
OKay I like your way, it matches the get caps too!
GetMetadatarequestsGetMapwithout specifying dimension values in the query params