Simple refactoring of xuint classes #243
Conversation
| // TODO: Add WorkerExecutor and the Gradle Worker API to execute in parallel if there are no dependencies. | ||
| // Any task with zero defined outputs is not cacheable, which should be enough for all run tasks. | ||
| // TODO: Make the module path/set pattern filterable for the module DSL. | ||
| public abstract class XtcTestTask extends XtcBaseRunTask implements XtcRuntimeExtension { |
There was a problem hiding this comment.
Looks good. Let me know if you need help figuring out any DSL modifications, it should be relatively staightforward by looking at what is there already, but there are some hidden traps.
One thing that we want to do is to run the Gradle configuration cache, which will significantly speed up the pre-build phase of the gradle jobs - this requires that we do not store projects anywhere in the plugin, which is possible to do, but requires some rewrites. Enabling the configuration cache will tell us what goes wrong and why, and I was hoping to get a volunteer to this fairly self contained task.
| javax-activation = { module = "com.sun.activation:javax.activation", version = "1.2.0" } | ||
| jakarta-xml-bind-api = { module = "jakarta.xml.bind:jakarta.xml.bind-api", version.ref = "jakarta" } | ||
| jaxb-runtime = { module = "org.glassfish.jaxb:jaxb-runtime", version.ref = "jakarta" } | ||
| jline = { module = "org.jline:jline", version.ref = "jline" } | ||
| mockito = {module = "org.mockito:mockito-core", version = "5.11.0"} | ||
|
|
There was a problem hiding this comment.
Hitting ctrl-alt-L in intelliJ adds trailing after-brace spaces for me, so that I don't have to think too much about indentation, but I'm not sure if it's a personal setting or propagated to our codebase. We should work on IDE-environment consitency together with language support. I did add support for the Oracle-Sun Java code standard with checkstyle, but this seems to be a thing no one wants to migrate too, and is disabled. The Plugin java code does pass it, though. Personally, as long as something is consistent, it doesn't matter how it looks, I can read it. The Coherence standard is the only one I have had trouble doing that with, and it only partly has to do with brackets on single lines makes longer methods and frequent page ups / page downs with a laptop size screen. :-). We should likely implement a plugin for an official XTC code standard too, and only have one.
|
I'm closing this PR as the changes have been merged into PR #241 |
This is a refactoring suggestion for JK