Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented few operations for the wasm instruction set #962

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

anutosh491
Copy link
Contributor

@anutosh491 anutosh491 commented Oct 25, 2023

The following operations would be implemented through the PR

  • reduce_max
  • reduce_min
  • swizzle
  • bitwise_cast
  • shuffle
  • fast_cast

serge-sans-paille added a commit that referenced this pull request Oct 29, 2023
This remove duplicate code for various Intel implementation and should
also help for #962.
serge-sans-paille added a commit that referenced this pull request Oct 30, 2023
…he int32 conversion is available

This remove duplicate code for various Intel implementation and should
also help for #962.
serge-sans-paille added a commit that referenced this pull request Oct 30, 2023
…he int32 conversion is available

This remove duplicate code for various Intel implementation and should
also help for #962.
serge-sans-paille added a commit that referenced this pull request Oct 31, 2023
…he int32 conversion is available

This remove duplicate code for various Intel implementation and should
also help for #962.
serge-sans-paille added a commit that referenced this pull request Oct 31, 2023
…he int32 conversion is available

This remove duplicate code for various Intel implementation and should
also help for #962.
reduce_max, reduce_min, swizzle, shuffle, bitwise_cast, fast_cast
@anutosh491 anutosh491 force-pushed the remaining_ops_impl branch 2 times, most recently from 46f5fc9 to 2eaa6ee Compare November 1, 2023 13:08
@anutosh491
Copy link
Contributor Author

anutosh491 commented Nov 2, 2023

cc @JohanMabille not sure if the failing check is related to the changes on the branch. I think they might not be related :(

Otherwise the changes are ready from my side.

@JohanMabille
Copy link
Member

The failure is indeed unrelated, I need to update the SDE version.

@JohanMabille
Copy link
Member

@anutosh491 I've fixed the issue on master, can you rebase your branch to check everything is fine?

@JohanMabille JohanMabille merged commit 105658a into xtensor-stack:master Nov 2, 2023
49 checks passed
@anutosh491 anutosh491 deleted the remaining_ops_impl branch November 3, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants