Skip to content

Commit

Permalink
Bump version
Browse files Browse the repository at this point in the history
  • Loading branch information
@xtrinch
xtrinch committed Mar 31, 2022
1 parent 68403ed commit 836077e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fcm_django/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
__author__ = "xTrinch"
__email__ = "[email protected]"
__version__ = "1.0.10"
__version__ = "1.0.11"


class NotificationError(Exception):
Expand Down

3 comments on commit 836077e

@xblitz
Copy link

@xblitz xblitz commented on 836077e May 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just my opinion, but I feel this should have been 1.1.0 , so if we follow Major.Minor.patch , so adding new feature I feel should be a Minor bump. only bump the patch when you fix a bug. what do you think? (for next time)

@xblitz
Copy link

@xblitz xblitz commented on 836077e May 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I think its the 1.0.10 that should have been 1.1.0 , since thats the one that added a new feature (send topic message) , and this one should have been 1.1.1

anyways it's just an opinion! thanks for your work :)

@xtrinch
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thakn you, will keep in mind for the future, major.minor.patch system sounds good

Please sign in to comment.