Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user files via elisp-demos-user-files, always show Demos section and include an "[Add]" button #18

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

sachac
Copy link
Contributor

@sachac sachac commented Jan 16, 2024

Thanks for making this package! I've been slowly getting the hang of adding my notes to functions, and it's really helpful to have the examples right there. I wanted to have my own notes file so that I could try more personal notes in there before possibly contributing them, and so that I could keep those notes even after upgrading. I also wanted to make it easier to add examples right from the Helpful section for Demos. Would you consider this patch? @xenodium confirmed being able to use it too.

sachac and others added 8 commits January 12, 2024 06:02
* elisp-demos.el (elisp-demos-user-files): New user option.
(elisp-demos--search): Search user files as well. Use
org-find-exact-headline-in-buffer to allow TODO keywords and tags.
Copy to the end of the subtree.
(elisp-demos-add-demo): Add to user file if specified. Use
org-entry-get to get the current heading in order to allow TODO
keywords and tags.
(elisp-demos-advice-helpful-update): Add an [Add] button.
Automatically insert function name into added source block
@xuchunyang xuchunyang merged commit ecc8412 into xuchunyang:master Jan 16, 2024
0 of 6 checks passed
@xuchunyang xuchunyang mentioned this pull request Jan 16, 2024
@xuchunyang
Copy link
Owner

Thanks for the PR. I've merged it and make some followup changes in #19, mostly to support older versions of Emacs in order to pass the checks.

xuchunyang referenced this pull request Jan 19, 2024
Because now this is easier than elisp-demos-find-demo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants