Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase first character of a translation key #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Uppercase first character of a translation key #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/main/resources/CKEditor/Translations.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ckeditor.admin.reset.confirmation=Are you sure you want to restore the default c
ckeditor.plugin.link.options=Options
ckeditor.plugin.link.anchor=Anchor
ckeditor.plugin.link.queryString=Query String
ckeditor.plugin.link.defaultLabel=type the link label
ckeditor.plugin.link.defaultLabel=Type the link label
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text (and the link label in general) is inserted in-line, most probably in the middle of a sentence so I'm not convinced that it should start with an upper case letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://snag.gy/ioyfVq.jpg See? "Find a page" with a uppercase and "type the link label" with lowercase but I understand what you mean ... You can reject my PR if you wish :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed https://snag.gy/ioyfVq.jpg needs to be fixed (either in code with a StringUtils.capitalize() or in transaltion).

Copy link
Contributor

@evalica evalica May 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marius refers that if you insert a label using the modal and leave the default value it will get inserted (in most cases) inside a phrase, not at the beginning (to justify the capitalization), see
link

Now question A is: how many users edit the link label inside the modal vs. inside the editor textarea?

Copy link
Contributor

@evalica evalica May 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question B: do we need to provide a default value? or can we just use a placeholder for the input?

  • Depends on the answer to A, since if we add a link without a value, it will be hard for the user to know where the link starts/ends.
  • A solution would be to make the "Display Text" mandatory, but this will break cases when link displays the page name if no link value is provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the same key is used for 2 different use cases then we should probably introduce a new key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not for 2 different use cases, the key is used as value so it gets inserted inside the text.

ckeditor.plugin.link.openInNewTab=Open Link in New Tab

ckeditor.plugin.macro.placeholder=macro:{0}
Expand Down