Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22523: Hitting the Enter key in fields on XWiki pages opens the hamburger content menu #3552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Oct 10, 2024

Jira URL

Changes

Description

  • Added type=button on the edit form buttons

Clarifications

  • Those buttons were added recently for semantics.
    • The breadcrumb caret was non semantic, it became a button when reworking the accessibility of the breadcrumb.
    • The moreAction was a link, it got modified to a button in d5bc04d
  • Those butttons without a type were triggered instead of the default form action. Adding a type on both of them ensured that pressing enter on a form input would correctly submit the form.

Screenshots & Video

None, no visual change.

Executed Tests

Manual tests to reproduce the bug reported. With the changes, pressing enter properly started the preview mode.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 15.10.X
    • 16.4.X
      Both of the causes got merged on both of those branches.

… hamburger content menu

* Added type=`button` on the edit form buttons (that are not here for form submission) so that we avoid mistakenly triggering them implicitely.
@Sereza7 Sereza7 added backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch. backport stable-16.4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants