Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pressing TAB in the editor #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix pressing TAB in the editor #134

wants to merge 1 commit into from

Conversation

wkiril
Copy link

@wkiril wkiril commented Oct 25, 2019

Pressing TAB key should insert TAB symbol in the editor. closes #132

@xy2z
Copy link
Owner

xy2z commented Oct 26, 2019

Thanks, but after testing I found a few issues

  • If shift+tab is pressed, it should not insert a tab.
  • When I refresh the page, the tab is gone in the editor. (it is saved in the database, so it's on rendering)
  • When pressing tab in a list it should not insert a tab, since tiptap already has a event for this - i'm not sure how this can be detected.

@wkiril
Copy link
Author

wkiril commented Oct 27, 2019

alright, I'll try to address those issues, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing TAB in the editor should insert a TAB
2 participants