Feature/precision library #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 28, 2021 22:07
| @@ -45,15 +45,19 @@ public void Lambert93BugTest() { | |||
| LambertPoint pt = Lambert.convertToWGS84Deg(668832.5384, 6950138.7285, LambertZone.Lambert93); | |||
| assertEquals(2.56865, pt.getX().doubleValue(), 0.0001); | |||
| assertEquals(49.64961, pt.getY().doubleValue(), 0.0001); | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| public void LambertIIExtendedToWgs84Test() { | |||
There was a problem hiding this comment.
I detect that this code is problematic. According to the Bad practice (BAD_PRACTICE), Nm: Method names should start with a lower case letter (NM_METHOD_NAMING_CONVENTION).
Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized.
There was a problem hiding this comment.
Hello
I left the test method names exactly like they were in the initial repo.
Yes, this is bad practice, but fixing this was not part of my reasons for this pull request.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've redone your translation of the initial algorithm using the Apfloat library.
There were some issues in your translation in the following methods:
cartesianToGeographic
geographicToLambertAlg003
latitudeISOFromLat
I've had to modify some reference test values because of minor differences caused by the precision algorithm.
Please let me know if there's any other test case you would like me to add.
Thank you.