Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extensible type conversion #430

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

clayreimann
Copy link
Contributor

@clayreimann clayreimann commented Mar 10, 2017

I'd love input from @DeathByTape and @aklish. The only sticking point that I see is we handle type conversion from a static function, so if you (for whatever reason) spun up 2 different Elide instances with different conversion sets the last one to be created would stomp on converters.

@wcekan
Copy link
Contributor

wcekan commented Mar 10, 2017

How is does this work with Jackson .addSerializer and ConvertUtils.register?

@DennisMcWherter
Copy link
Collaborator

@clayreimann you're right. We wouldn't want to stomp on two versions of Elide running in the same JVM. Arguably this could be mitigated by simply running 2 JVM's, but for various reasons that could add unnecessary complexity.

Is it possible to add the converter directly to the ElideSettings object and pass it with the RequestScope? (ElideSettings are automatically passed around in the RequestScope object).

@DennisMcWherter
Copy link
Collaborator

Update on this?

@DennisMcWherter
Copy link
Collaborator

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants