Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screwdriver.yaml #136

Merged
merged 7 commits into from
Dec 20, 2019
Merged

Update screwdriver.yaml #136

merged 7 commits into from
Dec 20, 2019

Conversation

dwighthubbard
Copy link
Contributor

@dwighthubbard dwighthubbard commented Dec 19, 2019

This is to address the lack of manylinux1 wheels as specified in issue #137

Add manylinux1 support and run functional tests against manylinux1, manylinux2010 and manylinux2014 packages

The new workflow based on the screwdriver.yaml in this pull request looks like:

Screen Shot 2019-12-19 at 1 48 07 PM

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@mattip
Copy link

mattip commented Dec 19, 2019

Is there a way to get screwdriver to use the manylinux2010 docker image to build both manylinux1 and manylinux2010 packages? The manylinux2010 auditwheel tool supports that, I don't know anything about screwdriver and if it exports that as an option. That would save a build job.

@dwighthubbard
Copy link
Contributor Author

The manylinux1 build container is based on manylinux5, the manylinux2010 build container is based on centos6 and the manylinux2014 container is based on centos7.

The CI pipeline for this project has 3 package publish jobs defined

  publish_pypi:
    # This template by default in a manylinux2010 container and
    # publishes sdist and manylinux2010 wheels
    template: python/package_python
    environment:
      PUBLISH: True
    requires: [verify_test_pkg, verify_test_pkg_ml1, verify_test_pkg_ml2014]

  publish_pypi_ml1_64:
    template: python/package_python
    image: manylinux1_64
    environment:
      PACKAGE_TAG: False
      PACKAGE_TYPES: wheel
      PUBLISH: True
    requires: [verify_test_pkg, verify_test_pkg_ml1, verify_test_pkg_ml2014]
    
  publish_pypi_ml2014:
    template: python/package_python
    image: manylinux2014
    environment:
      PACKAGE_TAG: False
      PACKAGE_TYPES: wheel
      PUBLISH: True
    requires: [verify_test_pkg, verify_test_pkg_ml1, verify_test_pkg_ml2014]

The three publish jobs this pull request has use the same package_python template but differ in the docker container image they are using. This allows the packages to be built with 3 different manylinux docker containers.

Publish with the correct image
@dwighthubbard dwighthubbard merged commit 28f7406 into master Dec 20, 2019
@dwighthubbard dwighthubbard deleted the manylinux1_support branch January 25, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants