Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatedRoadConnectionPath serialization errors #12097

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

yairm210
Copy link
Owner

@yairm210 yairm210 commented Aug 9, 2024

Somehow the custom serialization worked for everything except for within lists, which looks like it uses its own nonsense.
So we're rolling back this change, and temporarily disabling the saving of the list (MapUnit.automatedRoadConnectionPath) to allow games to continue normally
Resolves #12095

@yairm210
Copy link
Owner Author

yairm210 commented Aug 9, 2024

release patch

@yairm210 yairm210 merged commit cf202c2 into master Aug 9, 2024
5 checks passed
@yairm210 yairm210 deleted the vector2-serializer-removal-due-to-errors branch August 9, 2024 07:28
@SomeTroglodyte
Copy link
Collaborator

worked for everything except for within lists

I mentioned something similar in the past few weeks somewhere... This behaves possibly quite different between setSerializer and implements Serializable - but these hooks both are not the first tests in Gdx's decision tree. For example, ClassReflection.isAssignableFrom(Collection.class, type) absolutely moronically trumps both classToSerializer and Serializable - Json.java line 998.

... which seems exactly what we ran into here. Only solution is to ensure containers aren't recognizable as Java Collection or have their own hook. Or avoid Gdx. Or fork Gdx and fix that idiocy.

Sorry I didn't remember and warn earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplayer Next Turn Crash in v4.12.18 - SOLVED 4.12.18-patch1
2 participants