Let AI choose healing promotions #12728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simulation data: |
yairm210
reviewed
Dec 31, 2024
Comment on lines
+185
to
+186
| availablePromotions.filter { it.hasUnique(UniqueType.OneTimeUnitHeal) } //choose healing promotions only when beneficial | ||
| else availablePromotions.filterNot { it.hasUnique(UniqueType.SkipPromotion) } |
There was a problem hiding this comment.
What if we don't have any promotion with a one time heal? We should default to all
There was a problem hiding this comment.
True, hadn't thought of that.
There was a problem hiding this comment.
I suppose this works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently filtering out the healing promotion from consideration it seems, even though it can be the best choice.
Note that 60hp treshold is a bit arbitrary, it may be worthwhile to test with a higher or lower treshold.