Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testability #96

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Improve testability #96

merged 3 commits into from
Jul 8, 2024

Conversation

yamadashy
Copy link
Owner

Improve Testability by Separating DOM Operations from ChannelGrouper

Purpose

This PR aims to enhance the testability and maintainability of our Slack Channels Grouping extension by separating DOM manipulation logic from the core grouping logic.

Changes

  1. Introduced a new ChannelManipulator interface to abstract DOM operations.
  2. Created DomChannelManipulator to handle DOM-specific operations.
  3. Refactored ChannelGrouper to use the ChannelManipulator interface, removing direct DOM dependencies.
  4. Implemented a MockChannelManipulator for testing purposes.
  5. Updated ChannelGrouper to handle prefix extraction, which was previously done in DomChannelManipulator.

@yamadashy yamadashy merged commit 0b08e46 into main Jul 8, 2024
3 checks passed
@yamadashy yamadashy deleted the feature/improve-testability branch July 8, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant