Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Testability by Separating DOM Operations from ChannelGrouper
Purpose
This PR aims to enhance the testability and maintainability of our Slack Channels Grouping extension by separating DOM manipulation logic from the core grouping logic.
Changes
ChannelManipulator
interface to abstract DOM operations.DomChannelManipulator
to handle DOM-specific operations.ChannelGrouper
to use theChannelManipulator
interface, removing direct DOM dependencies.MockChannelManipulator
for testing purposes.ChannelGrouper
to handle prefix extraction, which was previously done inDomChannelManipulator
.