Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated NimYAML to 0.16.0 #19

Merged
merged 2 commits into from
Dec 28, 2021
Merged

updated NimYAML to 0.16.0 #19

merged 2 commits into from
Dec 28, 2021

Conversation

flyx
Copy link
Contributor

@flyx flyx commented Oct 22, 2021

This updates NimYAML to current 0.16.0 release.

  • uses alpine:edge which provides a decently up-to-date nim package, dropping the requirement of manually installing nim. Sadly the package is not contained in any stable release yet. Testing showed that this does not lead to errors during consolidation into the apline-runtime-static image.
  • simplifies the testing code; +STR/-STR are now provided by NimYAML

@perlpunk
Copy link
Member

Hey @flyx !

I have to try this out especially with the two Haskell libaries which had problems with the newer alpine images.
See #8

So I might not be able to update this until we resolve the Haskell issues

@flyx
Copy link
Contributor Author

flyx commented Oct 22, 2021

Hi @perlpunk :)

As I understand it, alpine edge is only used for the isolated NimYAML build image, so other images wouldn't be affected. Alpine seems to make a new release from edge in November so it might be worth to wait for that.

Maybe using a newer release can help fix the Haskell problem as well? Did you try using the 3.14.0 branch yet? It seems to have a newer ghc version available…

@perlpunk
Copy link
Member

It's true that the image is isolated, but we still build the yaml-editor from it, and this currently only works with an image having all libraries.
At some point I would like it to work with separate independent images, but for now...

I'll try out the haskell stuff on the newest alpine and see if it works...

@perlpunk
Copy link
Member

I tested alpine 3.15 but the haskell stuff still doesn't work, so I just updated NimYAML, thanks =)
Looks good on the test matrix: https://matrix.yaml.info/

@perlpunk perlpunk closed this Nov 19, 2021
@perlpunk perlpunk reopened this Dec 17, 2021
@perlpunk
Copy link
Member

Finally I have a solution where I can just use independent images for each runtime, look for "daemon" in the readme.
Anyway, now I can update the nim builder.
Maybe you want to rebase your PR?

@flyx
Copy link
Contributor Author

flyx commented Dec 21, 2021

Okay, since NimYAML is already updated I just simplified the dockerfile to use the Nim package from alpine:3.15.

@perlpunk perlpunk merged commit 50e3fe5 into yaml:master Dec 28, 2021
@perlpunk
Copy link
Member

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants