Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require rest of Timer classes #131

Closed
wants to merge 1 commit into from

Conversation

Sija
Copy link

@Sija Sija commented May 21, 2019

Fixes #129
Closes #130

@ritikesh
Copy link
Contributor

ritikesh commented May 21, 2019

I opened a PR(#130) for this almost 2 months back. Don't think the Yam folks care. 😄And not sure why you would want to raise another PR and make the exact same changes that I've and want to close my PR?

@Sija
Copy link
Author

Sija commented May 21, 2019

@ritikesh Your PR changes more than that (aliasing), so in hope to make it a no-brainer decision, I've decided to open another one, with the changes strictly related to issue at hand.

@Sija
Copy link
Author

Sija commented May 27, 2019

@matthewshafer ping

@matthewshafer
Copy link
Collaborator

This should be fixed with #130. Thanks for pinging me though because that let me know my notification settings were removed (it's a long story).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uninitialized constant Circuitbox::Timer::Null (NameError)
3 participants