Fix for #94 #99
Merged
Fix for #94 #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've attempted a fix, any thoughts? |
| public class NonElementFieldsTest { | ||
|
|
||
| @Test | ||
| public void non_element_private_fields_should_not_be_decorated_as_elements() { |
There was a problem hiding this comment.
please always use camelCase notation
|
Updated. |
| return decorateWebElementList(loader, field); | ||
| } | ||
| return null; | ||
| } catch (ClassCastException ignore) { |
There was a problem hiding this comment.
Either log or rethrow this exception. 
|
SonarQube analysis reported 1 issue:
Watch the comments in this conversation to review them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting PR for #94 after doing a bad job of conflating two different issues on the same branch.