Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr7051 suggestions #9

Open
wants to merge 13 commits into
base: development
Choose a base branch
from
Open

Pr7051 suggestions #9

wants to merge 13 commits into from

Commits on Feb 6, 2023

  1. Extract Secp521r1 from the prototype 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    c221e79 View commit details
    Browse the repository at this point in the history

  2. Fix Secp521r1 reduction 

    The prototype calculated with wrong limb size and not taken into account
the overflow in the shared limb.

Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    32fa5cc View commit details
    Browse the repository at this point in the history

  3. Change the ecp_mod_p521_raw to be testable 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    23c47f5 View commit details
    Browse the repository at this point in the history

  4. Add test generation support for the ecp module 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    23b58e5 View commit details
    Browse the repository at this point in the history

  5. Add test generation for ecp_mod_p521_raw 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    309801c View commit details
    Browse the repository at this point in the history

  6. Add documentation 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    14eb502 View commit details
    Browse the repository at this point in the history

  7. Rename function to follow naming convention 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    aa11ef4 View commit details
    Browse the repository at this point in the history

  8. Fix pylint issues 

    Create a new function for calculating the number of hex digits needed
for a certain amount of limbs.

Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    0f83e15 View commit details
    Browse the repository at this point in the history

  9. Fix coding style issues 

    Signed-off-by: Gabor Mezei <[email protected]>
    @gabor-mezei-arm
    gabor-mezei-arm committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    27977fc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Revert changes to mod_p521 flow 

    It is not necessary to save the middle limb upfront as overwriting it is
the desired result: in the first step we are reducing modulo
2^{512+biL}.

Arguably, the original flow is more intuitive and easier to see the idea
behind it.

Signed-off-by: Janos Follath <[email protected]>
    @yanesca
    yanesca committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    c04f8ec View commit details
    Browse the repository at this point in the history

  2. Add corner case to mod_p521 tests 

    Signed-off-by: Janos Follath <[email protected]>
    @yanesca
    yanesca committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1a2647d View commit details
    Browse the repository at this point in the history

  3. modp521: apply naming conventions 

    Apply the usual parameter name and align the local variables and
comments. This naming diverges from the standard notation, but this is
beneficial as our variable meanings diverge as well and the difference
can help avoiding confusion.

Signed-off-by: Janos Follath <[email protected]>
    @yanesca
    yanesca committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1194ece View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. mod_p521: document reduction algorithm 

    Signed-off-by: Janos Follath <[email protected]>
    @yanesca
    yanesca committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    fc9c0d7 View commit details
    Browse the repository at this point in the history