Fix flapping of state timeout tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous verisons were relying on the fact that `fw cli check` prints 2sec ago when seening states. But that depends on many factors, and sometimes it can be faster so we see 1sec ago, which results in "cli_check" step fail. Now we just check whether the state is present with "grep -q"
ol-imorozko
force-pushed
the
fix-statetimeout-test
branch
from
ba6ee61 to
31dfd3d
Compare
GeorgyKirichenko
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous verisons were relying on the fact that
fw cli checkprints 2sec ago when seening states. But that depends on many factors, and sometimes it can be faster so we see 1sec ago, which results in "cli_check" step fail.Now we just check whether the state is present with "grep -q"