Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testing of statuspage_metric and checking of null metric attributes on read operations #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sealneaward
Copy link

@sealneaward sealneaward commented Apr 4, 2024

Adding null checks to the metric resource, since the resource will fail on a null pointer reference without it.
This is because the Atlassian StatusPage API does not return default values for these non-required fields if they are not set at creation.

I also added to the description of metric_base_uri parameter of the metric_provider resource, since it is required for Datadog type metric providers.

I also re-enabled the statuspage_metric test with what I believe as a default DataDog metric.
I do have access to a DataDog account with metrics, so I can help collaborate on testing and development related to DataDog related resources on the project.

I also made some corrections to the documentation on the statuspage_metric resource, since this states certain parameters are required when they are not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant