Enable testing of statuspage_metric and checking of null metric attributes on read operations #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding null checks to the metric resource, since the resource will fail on a null pointer reference without it.
This is because the Atlassian StatusPage API does not return default values for these non-required fields if they are not set at creation.
I also added to the description of
metric_base_uri
parameter of themetric_provider
resource, since it is required for Datadog type metric providers.I also re-enabled the
statuspage_metric
test with what I believe as a default DataDog metric.I do have access to a DataDog account with metrics, so I can help collaborate on testing and development related to DataDog related resources on the project.
I also made some corrections to the documentation on the
statuspage_metric
resource, since this states certain parameters are required when they are not.