Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node 22 package json loader (#57) @faulpeltz #57

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

faulpeltz
Copy link

The argument order in deserializePackageJSON() was mixed up, confusing exports and imports for ESM declarations in package json.

This fixes the module resolution issue in yao-pkg/pkg#87

- fix call to deserializePackageJSON()
Copy link
Member

@robertsLando robertsLando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙏🏼

@robertsLando robertsLando changed the title fix: node 22 package json loader fix: node 22 package json loader (#57) @faulpeltz Oct 22, 2024
@robertsLando robertsLando merged commit ea8746d into yao-pkg:main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants