Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump ink from 3.2.0 5.1.0, bump react from 17.0.2 to 18.3.1 #6648

Closed
wants to merge 2 commits into from
Closed

chore: bump ink from 3.2.0 5.1.0, bump react from 17.0.2 to 18.3.1 #6648

wants to merge 2 commits into from

Conversation

wojtekmaj
Copy link
Contributor

Blocked by #6647

What's the problem this PR addresses?

This PR:

  • Bumps ink, react, @types/react dependencies.
  • As a result, makes Berry approximately 50 KB smaller (2.63 MiB -> 2.58 MiB).

How did you fix it?

  • Bumped dependencies
  • Reviewed breaking changes (the only meaningful breaking change in ink is Node.js requirement raised to 18.0, which is already the requirement in Berry, so it's not a problem).

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@wojtekmaj
chore: switch esbuild output format from iife to esm
f7d128d 
This setting currently blocks Berry from using ESM modules that use top-level await (e.g. ink).
@wojtekmaj
chore: bump ink from 3.2.0 5.1.0, bump react from 17.0.2 to 18.3.1
1d2a96f
@wojtekmaj wojtekmaj marked this pull request as draft January 7, 2025 14:29
@wojtekmaj wojtekmaj closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wojtekmaj