Adaptations to work inside a container #669
Conversation
It was executed locally (ie. on the inst-sys during installation) due to bsc#900039. But that does not longer apply.
| @@ -131,7 +131,7 @@ def disable | |||
| end | |||
|
|
|||
| def encrypt(password) | |||
| result = Yast::Execute.locally("/usr/bin/grub2-mkpasswd-pbkdf2", | |||
| result = Yast::Execute.on_target("/usr/bin/grub2-mkpasswd-pbkdf2", | |||
There was a problem hiding this comment.
well, another option I see is to have that mkpasswd installed locally as it does not need to be on target system if it is decided to split it from grub2. We need on target system mainly tools used to create config and install stage1 due to new kernel and new grub2 modules - so grub2-mkconfig and grub2-install.
In general I am not against change if it is properly tested during upgrade from old SLE...do we still support migration from SLE11?
There was a problem hiding this comment.
I decided to go this way because is simpler and I don't think grub2-mkpasswd-pbkdf2 will be split from the grub2 package in the foreseeable future.
That tool is included in the grub2 package even for SLE-11. So if you are upgrading such a system the tool is already in the target.
There was a problem hiding this comment.
Bearing in mind your comment at https://github.com/yast/yast-bootloader/pull/669/files#r929612013, it LGTM.
Please, do not forget to report the bug mentioned in the description
During manual testing I found the grub2 password is logged plain at the YaST logs. Bug to be reported.
|
✔️ Public Jenkins job #115 successfully finished |
|
✔️ Internal Jenkins job #76 successfully finished |
Problem
yast2-bootloader does not work inside a container out of the box (see bsc#1199840). There are several things that need to be fixed:
grub2-mkpasswd-pbkdf2is executed locally (ie. in the container) instead of the target system due to historical reasons that do not longer apply.Solution
As mentioned, the first problem is addressed in a separate pull request at another repository.
This fixes the second problem by making sure
grub2-mkpasswd-pbkdf2is executed in the target system.Problem 3 remains to be fixed (and likely will be addressed by an upcoming pull request at yast-yast2).
Testing
grub2-mkpasswd-pbkdf2is executed during the proposal phase, whenExecute.locallyandExecute.on_targetare still equivalent.Notes
During manual testing I found the grub2 password is logged plain at the YaST logs. Reported as bsc#1201962