Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluously BuildRequires: HANA-Firewall #36

Merged
merged 202 commits into from
Nov 20, 2023
Merged

Conversation

varkoly
Copy link
Collaborator

@varkoly varkoly commented Aug 7, 2023

Problem

The BuildRequires: HANA-Firewall couses a lot problems but it is superfluously.
The parameter global_allocation_limit and global_alloc_limit were not evaluated

Solution

Remove superfluously BuildRequires
Evaluate the parameter.

lslezak and others added 30 commits March 31, 2021 08:52
SUSE SAP HA Yast wizard for HANA doesn´t configure the HANA hooks.
This reads the proposal for the modules watchdog and fence.
This is neccessary when reading an earlier configuration.
max lenngth 256
all ascii is allowed 33-126 instead of "*" and "/".
… from 33 until 125

expect of '*' and '/'. The identifier can be 256 character long
However, for security and technical reasons, we only allow alphanumeric characters as well as '-' and '_'.
The identifier must not be longer than 30 characters and it must be minimum 2 long.
Add some check for SID and site identifier.
yast2-sap-ha: S:M:24423:276258: csync2 configuration not enabled
@coveralls
Copy link

coveralls commented Aug 16, 2023

Pull Request Test Coverage Report for Build 6928396064

  • 247 of 765 (32.29%) changed or added relevant lines in 37 files are covered.
  • 24 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.007%) to 29.564%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/sap_ha/configuration/base_config.rb 8 9 88.89%
src/lib/sap_ha/configuration/ntp.rb 9 10 90.0%
src/lib/sap_ha/configuration/watchdog.rb 6 7 85.71%
src/lib/sap_ha/semantic_checks.rb 4 5 80.0%
src/lib/sap_ha/system/network.rb 6 7 85.71%
src/clients/sap_ha_rpc.rb 0 2 0.0%
src/lib/sap_ha/system/watchdog.rb 7 9 77.78%
src/lib/sap_ha/wizard/rich_text.rb 0 3 0.0%
src/lib/sap_ha/system/shell_commands.rb 3 8 37.5%
src/lib/sap_ha/wizard/overview_page.rb 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/clients/sap_ha_rpc.rb 1 0.0%
src/lib/sap_ha/configuration/cluster.rb 1 61.9%
src/lib/sap_ha/system/connectivity.rb 1 0.0%
src/lib/sap_ha/wizard/base_wizard_page.rb 1 0.0%
src/lib/sap_ha/wizard/hana_page.rb 1 0.0%
src/lib/sap_ha/wizard/join_cluster_page.rb 1 0.0%
src/lib/sap_ha/wizard/ntp_page.rb 1 0.0%
src/clients/sap_ha.rb 2 0.0%
src/lib/sap_ha/configuration/hana.rb 2 48.82%
src/lib/sap_ha/sap_ha_unattended_install.rb 2 0.0%
Totals Coverage Status
Change from base Build 6769270140: 0.007%
Covered Lines: 1208
Relevant Lines: 4086

💛 - Coveralls

@varkoly varkoly merged commit fe6437b into yast:master Nov 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants