Update base image, fix #370 #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20.04 (focal) base image --> sed 4.7.1 even after upgrade 24.04 (jammy) base image --> usher fails to build 22.04 as the base image builds and installs sed 4.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Ubuntu base image to in order to upgrade
sedto 4.8. 22.04 (jammy) was chosen as the new base image as usher does not compile when the base image is set to 24.04 (noble).I tested the resulting Docker image as described in #370 and confirmed that this fixes that issue, but I did not extensively test other usher functions.