Simplify fvim-osx-launcher #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use exec to directly launch fvim from a login shell
|
Hi! Thanks for your contribution! Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had a few issues with
HOMEnot being available in environment on a M1 Mac running Ventura and it got me testing things in the launcher. I found the whole "environment variable extracting" deal a bit complex for what it seems to want to do.I got fvim working fine after tuning a bit the file to just use exec to directly launch fvim from a login shell; so I'm sharing my modifications in case that's something you'd want to include (I'm not sure it will be good for all installations though).
Cheers,
Gerry