Fix custom text properties for semantic highlighting #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were supposed to allow users to set highlight groups for any token types that we don't understand, as servers can basically return anything they like. This didn't work and we just always complained about it. Now we trap the "text property type doesn't exist" error and warn then. This allows users to specify the missing ones to stfu the error. Also improved the message to point to the help.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4164 +/- ##
==========================================
- Coverage 89.02% 88.84% -0.18%
==========================================
Files 34 34
Lines 4390 4393 +3
==========================================
- Hits 3908 3903 -5
- Misses 482 490 +8 |
puremourning
commented
Jul 19, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @puremourning)
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were supposed to allow users to set highlight groups for any token types that we don't understand, as servers can basically return anything they like. This didn't work and we just always complained about it.
Now we trap the "text property type doesn't exist" error and warn then. This allows users to specify the missing ones to stfu the error. Also improved the message to point to the help.
closes #4161
This change is