Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup-java action #4186

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Update setup-java action #4186

merged 1 commit into from
Sep 14, 2023

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Sep 13, 2023

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

This silences thet GHA warning, similar to the changes in ycmd.


This change is Reviewable

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4186 (d40e1ef) into master (4f1dcf4) will increase coverage by 0.00%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4186   +/-   ##
=======================================
  Coverage   88.82%   88.83%           
=======================================
  Files          34       34           
  Lines        4395     4398    +3     
=======================================
+ Hits         3904     3907    +3     
  Misses        491      491           

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Sep 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

Thanks for sending a PR!

@mergify mergify bot merged commit 91ee858 into ycm-core:master Sep 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants