-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new ycmd #4190
Update to new ycmd #4190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)
a discussion (no related file):
Need to update README.md, it contains the clang version in a few places:
Please note that if using custom
clangd
orlibclang
it must match the
version that YCM requires. Currently YCM requires clang 16.0.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @bstaletic)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4190 +/- ##
==========================================
- Coverage 88.92% 88.83% -0.10%
==========================================
Files 34 34
Lines 4398 4398
==========================================
- Hits 3911 3907 -4
- Misses 487 491 +4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
a discussion (no related file):
Previously, puremourning (Ben Jackson) wrote…
Need to update README.md, it contains the clang version in a few places:
Please note that if using custom
clangd
orlibclang
it must match the
version that YCM requires. Currently YCM requires clang 16.0.1.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)
Mostly completer upgrades, and we are now python 3.12 ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to summarize:
- Ycmd updated, so now we are python 3.12 compatible.
- New tsserver requires node 14+, but we are saying 18+ because that is the only LTS version.
- Clangd fixed grammar in diagnostics.
- JDT reordered some fixits so no we need 3rd one not the 4th.
- CI is finally green (except for coverage being confused).
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale) (waiting on @puremourning)
Thanks for sending a PR! |
Mostly completer upgrades, and we are now python 3.12 ready.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
x
insidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
Now we are python 3.12 ready. For a more detailed look into the diff:
This change is