[READY] Handle multiple identical diagnostics in YcmShowDetailedDiagnostic popup #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4219 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.02%
==========================================
Files 34 34
Lines 4424 4425 +1
==========================================
+ Hits 3969 3971 +2
+ Misses 455 454 -1 |
bstaletic
force-pushed
the
detailed-diag-popup-revenge-of-the-sith
branch
from
cfed814
to
5e40ea8
Compare
puremourning
approved these changes
Feb 3, 2024
bstaletic
force-pushed
the
detailed-diag-popup-revenge-of-the-sith
branch
from
5e40ea8
to
cea2458
Compare
If a line for which detailed diagnostics are requested contains more than a single diagnostic with the same message, YCM will try `options.pop( 'col' )` more than once. We do not need to really iterate through the diagnostics once we have found the first one that is a match. If there's only one diag with the matching message, looping beyond that diagnostic is just a waste of time. If there's multiple diagnostics with the same message, it does not matter which one we display in the popup. Hence, the added break at the end of the loop.
|
Thanks for sending a PR! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
xinsidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
If a line for which detailed diagnostics are requested contains more than a single diagnostic with the same message, YCM will try
options.pop( 'col' )more than once.We do not need to really iterate through the diagnostics once we have found the first one that is a match. If there's only one diag with the matching message, looping beyond that diagnostic is just a waste of time. If there's multiple diagnostics with the same message, it does not matter which one we display in the popup.
Hence, the added break at the end of the loop.
This change is