Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle text as categoricals if sensitive=True #1415

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

alexbarros
Copy link
Contributor

fixes #1377
Handles text variables as categoricals if sensitive is true. Here is an example of a column with random text:

sensitivity = False:
image
sensitivity = True
image

@alexbarros alexbarros requested a review from aquemy August 7, 2023 11:53
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 79.83% and project coverage change: -0.01% ⚠️

Comparison is base (d8c3104) 89.70% compared to head (745c4d0) 89.69%.
Report is 9 commits behind head on develop.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1415      +/-   ##
===========================================
- Coverage    89.70%   89.69%   -0.01%     
===========================================
  Files          194      194              
  Lines         6254     6260       +6     
===========================================
+ Hits          5610     5615       +5     
- Misses         644      645       +1     
Flag Coverage Δ
py3.8-ubuntu-22.04-pandas 89.69% <79.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
setup.py 0.00% <ø> (ø)
src/ydata_profiling/model/pandas/__init__.py 100.00% <ø> (ø)
tests/unit/test_describe.py 94.54% <ø> (ø)
tests/unit/test_output.py 100.00% <ø> (ø)
src/ydata_profiling/profile_report.py 81.42% <50.00%> (ø)
src/ydata_profiling/visualisation/plot.py 78.92% <59.37%> (ø)
...g/report/structure/variables/render_categorical.py 94.50% <66.66%> (-0.95%) ⬇️
..._profiling/model/pandas/timeseries_index_pandas.py 76.19% <76.19%> (ø)
src/ydata_profiling/model/timeseries_index.py 83.33% <83.33%> (ø)
src/ydata_profiling/report/structure/overview.py 93.33% <91.30%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexbarros alexbarros merged commit 346478c into develop Aug 7, 2023
22 checks passed
@alexbarros alexbarros deleted the fix/redact_text_vars branch August 7, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word clouds for text fields display information when in sensitive mode
3 participants