Skip to content

Commit

Permalink
Fix linter
Browse files Browse the repository at this point in the history
  • Loading branch information
vitalyisaev2 committed Oct 25, 2024
1 parent 3cb7463 commit e7b664e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
14 changes: 4 additions & 10 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,13 @@ test_coverage: integration_test_env_run
./fq-connector-go-tests -projectPath=$(PROJECT_PATH) -test.coverprofile=coverage_integration_tests.out
cat coverage_unit_tests.out | grep -v 'pb.go\|mock.go\|library' > coverage.out
cat coverage_integration_tests.out | grep -v 'atomic\|pb.go\|mock.go\|library' >> coverage.out
go tool cover -func=coverage.out

build_image_base:
docker build -t ghcr.io/ydb-platform/fq-connector-go:base -f ./Dockerfile.base .

build_image_release:
docker build --network=host -t ghcr.io/ydb-platform/fq-connector-go:latest -f ./Dockerfile.release .

cloc:
cloc ./app ./common ./tests --git
go tool cover -func=sudo apt install cloc

docker_compose_update:
go run ./tools/docker_compose_update -path="$(path)"

generate_docs:
python3 ./docs/generate.py ./docs

count_lines:
cloc --vcs=git . --exclude-dir=library,api --exclude-ext=pb.go
2 changes: 0 additions & 2 deletions app/server/datasource/rdbms/ydb/connection_native.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,6 @@ func (c *connectionNative) rewriteQuery(params *rdbms_utils.QueryParams) (string
buf.WriteString(fmt.Sprintf("PRAGMA TablePathPrefix(\"%s\");\n", c.dsi.Database)) //nolint:revive

for i, arg := range params.QueryArgs.GetAll() {
fmt.Println(i, arg.YdbType, arg.Value)
var primitiveTypeID Ydb.Type_PrimitiveTypeId

if arg.YdbType.GetOptionalType() != nil {
Expand All @@ -270,7 +269,6 @@ func (c *connectionNative) rewriteQuery(params *rdbms_utils.QueryParams) (string
default:
return "", fmt.Errorf("optional type contains no primitive type: %v", arg.YdbType)
}

} else {
primitiveTypeID = arg.YdbType.GetTypeId()
}
Expand Down

0 comments on commit e7b664e

Please sign in to comment.