Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect type naming changes in Protobuf-generated code #220

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

vitalyisaev2
Copy link
Member

@vitalyisaev2 vitalyisaev2 commented Dec 13, 2024

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 72.60274% with 20 lines in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (7f17f5b) to head (07d8fd6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
common/credentials.go 0.00% 4 Missing ⚠️
app/server/validate.go 78.57% 3 Missing ⚠️
app/server/data_source_collection.go 50.00% 2 Missing ⚠️
...ver/datasource/rdbms/logging/connection_manager.go 0.00% 2 Missing ⚠️
common/errors.go 80.00% 2 Missing ⚠️
app/bench/test_case_runner.go 0.00% 1 Missing ⚠️
app/client/connector/client.go 0.00% 1 Missing ⚠️
app/server/datasource/rdbms/data_source_factory.go 94.44% 1 Missing ⚠️
...tasource/rdbms/ms_sql_server/connection_manager.go 0.00% 0 Missing and 1 partial ⚠️
...rver/datasource/rdbms/oracle/connection_manager.go 0.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   63.66%   63.68%   +0.01%     
==========================================
  Files         114      114              
  Lines        7912     7916       +4     
==========================================
+ Hits         5037     5041       +4     
  Misses       2541     2541              
  Partials      334      334              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitalyisaev2 vitalyisaev2 changed the title Reflect type changes in generated code Reflect type naming changes in Protobuf-generated code Dec 13, 2024
@vitalyisaev2 vitalyisaev2 merged commit 5309cb2 into main Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants