-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved parameters for registration from server to storage config + added registration tests for nbs #1859
Merged
yegorskii
merged 10 commits into
main
from
users/yegorskii/move-registration-params-to-storage-config
Sep 4, 2024
Merged
moved parameters for registration from server to storage config + added registration tests for nbs #1859
yegorskii
merged 10 commits into
main
from
users/yegorskii/move-registration-params-to-storage-config
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 23, 2024 17:05
ece1b5c
to
48043ea
Compare
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 26, 2024 07:30
48043ea
to
5cc8e60
Compare
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 26, 2024 13:43
5cc8e60
to
b800800
Compare
qkrorlqr
requested changes
Aug 26, 2024
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 29, 2024 16:48
60d0af7
to
5a43410
Compare
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 30, 2024 14:50
20733d0
to
bf4e92d
Compare
yegorskii
force-pushed
the
users/yegorskii/move-registration-params-to-storage-config
branch
from
August 30, 2024 15:31
bf4e92d
to
5e2c1ba
Compare
qkrorlqr
reviewed
Sep 1, 2024
qkrorlqr
approved these changes
Sep 4, 2024
EvgeniyKozev
approved these changes
Sep 4, 2024
yegorskii
deleted the
users/yegorskii/move-registration-params-to-storage-config
branch
September 4, 2024 13:30
yegorskii
added a commit
that referenced
this pull request
Sep 10, 2024
…ed registration tests for nbs (#1859) * moved parameters for registration from server to storage config + added registration tests for nbs * update * update * update * fix ut * update * update * update * fix ut * remove extra new lines
yegorskii
added a commit
that referenced
this pull request
Sep 10, 2024
…ed registration tests for nbs (#1859) * moved parameters for registration from server to storage config + added registration tests for nbs * update * update * update * fix ut * update * update * update * fix ut * remove extra new lines
yegorskii
added a commit
that referenced
this pull request
Sep 10, 2024
…ed registration tests for nbs (#1859) * moved parameters for registration from server to storage config + added registration tests for nbs * update * update * update * fix ut * update * update * update * fix ut * remove extra new lines
yegorskii
added a commit
that referenced
this pull request
Sep 11, 2024
…ed registration tests for nbs (#1859) * moved parameters for registration from server to storage config + added registration tests for nbs * update * update * update * fix ut * update * update * update * fix ut * remove extra new lines
yegorskii
added a commit
that referenced
this pull request
Sep 11, 2024
* Refactor config handlers in filestore (#1758) * moved parameters for registration from server to storage config + added registration tests for nbs (#1859) * moved parameters for registration from server to storage config + added registration tests for nbs * update * update * update * fix ut * update * update * update * fix ut * remove extra new lines --------- Co-authored-by: Kirill Pleshivtsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.