Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disk Manager] improve incremental snapshots/images tests; bug fixes #1980

Merged
merged 8 commits into from
Sep 13, 2024
Merged

[Disk Manager] improve incremental snapshots/images tests; bug fixes #1980

merged 8 commits into from
Sep 13, 2024

Conversation

BarkovBG
Copy link
Collaborator

@BarkovBG BarkovBG commented Sep 9, 2024 •
edited by SvartMetal
Loading

#1980 (comment)

  • added base snapshot id check
  • added lock task id test
  • added TestImageServiceCreateIncrementalImageFromDisk
  • improve TestSnapshotServiceCreateIncrementalSnapshotWhileDeletingBaseSnapshot
  • bug fixes

#1636

@BarkovBG BarkovBG changed the title [Disk Manager] added base snapshot id check; added lock task id test [Disk Manager] improve incremental snapshots/images tests Sep 9, 2024
@BarkovBG BarkovBG marked this pull request as ready for review September 9, 2024 15:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1b1565d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5747 5743 0 0 2 2

@BarkovBG BarkovBG added large-tests Launch large tests for PR disk_manager Add this label to run only cloud/disk_manager build and tests on PR tasks Add this label to run only cloud/tasks build and tests on PR labels Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1b1565d.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1069 1064 0 1 2 2

@BarkovBG BarkovBG force-pushed the users/barkovbg/add_snapshots_tests branch 4 times, most recently from 8cf842d to 774efbd Compare September 11, 2024 14:52
@BarkovBG BarkovBG changed the title [Disk Manager] improve incremental snapshots/images tests [Disk Manager] improve incremental snapshots/images tests; bug fixes Sep 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 774efbd.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1080 1000 0 53 27 0

@BarkovBG BarkovBG force-pushed the users/barkovbg/add_snapshots_tests branch from 6ae2ae9 to a267951 Compare September 12, 2024 11:42
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a267951.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1071 1071 0 0 0 0

@BarkovBG BarkovBG mentioned this pull request Sep 12, 2024
Closed
@BarkovBG BarkovBG force-pushed the users/barkovbg/add_snapshots_tests branch from 20f7f8d to 280f898 Compare September 12, 2024 19:30
SvartMetal
SvartMetal previously approved these changes Sep 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 280f898.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1075 1054 0 8 11 2

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 57b6ca9.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1072 1068 0 0 2 2

@BarkovBG BarkovBG merged commit 4e5ea83 into main Sep 13, 2024
11 of 13 checks passed
@BarkovBG BarkovBG deleted the users/barkovbg/add_snapshots_tests branch September 13, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gy2411 gy2411 gy2411 approved these changes

@SvartMetal SvartMetal SvartMetal approved these changes

Assignees
No one assigned
Labels
disk_manager Add this label to run only cloud/disk_manager build and tests on PR large-tests Launch large tests for PR tasks Add this label to run only cloud/tasks build and tests on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BarkovBG @SvartMetal @gy2411