Deduce MediaKind from PoolKind while creating a disk from device #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komarevtsev-d
added
large-tests
drbasic
approved these changes
Sep 18, 2024
sharpeye
approved these changes
Sep 18, 2024
komarevtsev-d
added a commit
that referenced
this pull request
Sep 18, 2024
komarevtsev-d
added a commit
that referenced
this pull request
Sep 19, 2024
* Ability to disable node broker registration in the DA (#2038) * Ability to disable node broker registration in the DA * Fix typo in comment * Fix linkage * Fix local disks test (#2039) * Respond to HTTP requests while being in the deep idle state (#2045) * Respond to HTTP requests while being in the deep idle state * Review fixes * Fix blockstore-vhost-server deadlock before execvp call (#2052) * Fix vhost deadlock before execvp call * Make sure no allocations is done * Simlify the vhost server spawn (#2057) * Deduce MediaKind from PoolKind while creating a disk from device (#2061) * fix cmake build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2060
Правлю валенок, где мы всегда создаём SSD_NONREPLICATED с точки зрения DR, хотя диск может быть локальным