issue-2033: we should ignore DupCache entries with invalid types and proceed with request processing as if the entry didn't exist (for the case of request id collisions) #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proceed with request processing as if the entry didn't exist (for the case of request id collisions)
qkrorlqr
added
large-tests
…proceed with request processing as if the entry didn't exist (for the case of request id collisions) - cleanup
yegorskii
previously approved these changes
Sep 21, 2024
debnatkh
previously approved these changes
Sep 21, 2024
debnatkh
approved these changes
Sep 21, 2024
yegorskii
approved these changes
Sep 21, 2024
qkrorlqr
deleted the
users/qkrorlqr/issue-2033-collisions-and-invalid-type
branch
debnatkh
pushed a commit
that referenced
this pull request
Sep 21, 2024
…proceed with request processing as if the entry didn't exist (for the case of request id collisions) (#2097) * issue-2033: we should ignore DupCache entries with invalid types and proceed with request processing as if the entry didn't exist (for the case of request id collisions) * issue-2033: we should ignore DupCache entries with invalid types and proceed with request processing as if the entry didn't exist (for the case of request id collisions) - cleanup * issue-2033: updated ShouldValidateDupRequests ut
debnatkh
added a commit
that referenced
this pull request
Sep 21, 2024
…proceed with request processing as if the entry didn't exist (for the case of request id collisions) (#2097) (#2098) * issue-2033: we should ignore DupCache entries with invalid types and proceed with request processing as if the entry didn't exist (for the case of request id collisions) * issue-2033: we should ignore DupCache entries with invalid types and proceed with request processing as if the entry didn't exist (for the case of request id collisions) - cleanup * issue-2033: updated ShouldValidateDupRequests ut Co-authored-by: Andrei Strelkovskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2033