Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-2100: make GetErrorFromPreconditionFailed function (of blockstore SS proxy) look the same as the corresponding function of filestore SS proxy #2114

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

SvartMetal
Copy link
Collaborator

@SvartMetal SvartMetal commented Sep 23, 2024

Follow-up for work started at #2101.

There are three possible error messages:

  • Wrong version in VolumeConfig (blockstore)
  • Wrong version in Assign Volume (blockstore)
  • Wrong version in config (filestore)

We may use just Wrong version in in order to unify all of these messages.

#2100

yegorskii
yegorskii previously approved these changes Sep 23, 2024
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 78fd9f5.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5818 5816 0 2 0 0

…re SS proxy) look the same as the corresponding function of filestore SS proxy
@SvartMetal SvartMetal added the large-tests Launch large tests for PR label Sep 23, 2024
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 3be0b09.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6167 6167 0 0 0 0

@SvartMetal SvartMetal merged commit a157e9a into main Sep 24, 2024
12 of 19 checks passed
@SvartMetal SvartMetal deleted the users/svartmetal/issue-2100/2 branch September 24, 2024 09:23
SvartMetal added a commit that referenced this pull request Oct 14, 2024
…re SS proxy) look the same as the corresponding function of filestore SS proxy (#2114)
SvartMetal added a commit that referenced this pull request Oct 15, 2024
… for filestore SS proxy; cloud/storage/core/libs/ss_proxy should be able to backup path descriptions; extract TSSProxyActor from cloud/filestore - this actor implements DescribeScheme, ModifyScheme and WaitSchemeTx requests + small several small fixes (#2273)

* issue-757: check data that was written before static BS group destruction in local-emergency test (#2068)

* issue-757: should not unmount volume (in local-emergency test) before static BS group destruction in order to make emergency unexpected (#2079)

* issue-2100: make GetErrorFromPreconditionFailed function (of blockstore SS proxy) look the same as the corresponding function of filestore SS proxy (#2114)

* issue-2100: extract TSSProxyActor from cloud/filestore - this actor implements DescribeScheme, ModifyScheme and WaitSchemeTx requests (#2131)

* issue-2100: cloud/storage/core/libs/ss_proxy should be able to backup path descriptions (#2163)

* issue-2100: implement fallback mode for filestore SS proxy (#2226)

* issue-2100: fix TSSProxyTest.ShouldDescribeFileStoreInFallbackMode test (#2237)

* replace contrib/ydb and contrib/ydb/library/actors

* fix & add cmake lists

* fix cmake lists again

* fix cmake lists again and again

---------

Co-authored-by: Mikhail Montsev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large-tests Launch large tests for PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants