Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One line error printing & more clear warn message #298

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Aug 5, 2024

No description provided.

@pnv1 pnv1 requested a review from alex268 August 5, 2024 13:43
@pnv1 pnv1 self-assigned this Aug 5, 2024
@pnv1 pnv1 linked an issue Aug 5, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 46.47%. Comparing base (c02f9e7) to head (8f3ed25).

Files Patch % Lines
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 0.00% 4 Missing ⚠️
...ain/java/tech/ydb/topic/write/impl/WriterImpl.java 0.00% 4 Missing ⚠️
...in/java/tech/ydb/topic/impl/GrpcStreamRetrier.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     46.47%   46.47%           
  Complexity     1677     1677           
=========================================
  Files           303      303           
  Lines         12082    12085    +3     
  Branches       1207     1207           
=========================================
+ Hits           5615     5617    +2     
- Misses         6030     6031    +1     
  Partials        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 6cd96eb into master Aug 5, 2024
7 checks passed
@pnv1 pnv1 deleted the one-line-error-printing branch August 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues are ignored in topic stream errors
3 participants