Fixing race condition in AsyncReaderImpl::shutdown #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that occurs upon invocation of
AsyncReaderImpl::shutdown
when thehandlerExecutor
field is set.The problem we faced:
AsyncReaderImpl::shutdown
.GrpcStreamRetrier::shutdownImpl
->AsyncReaderImpl::onShutdown
->AsyncReaderImpl::handleReaderClosed
.handleReaderClosed
sends an action callingeventHandler.onReaderClosed
tohandlerExecutor
but does not wait for execution.AsyncReaderImpl::shutdown
returns.handlerExecutor
.handlerExecutor
rejects the action from the third step andeventHandler.onReaderClosed
is never called.