Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableClient implementation with QueryClient under hood #305

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

alex268
Copy link
Member

@alex268 alex268 commented Aug 19, 2024

No description provided.

@alex268 alex268 requested a review from pnv1 August 19, 2024 11:11
@alex268 alex268 self-assigned this Aug 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.47541% with 47 lines in your changes missing coverage. Please review.

Project coverage is 47.23%. Comparing base (16f2600) to head (bfbba60).
Report is 2 commits behind head on master.

Files Patch % Lines
...main/java/tech/ydb/query/impl/TableClientImpl.java 59.21% 27 Missing and 4 partials ⚠️
...src/main/java/tech/ydb/query/impl/SessionPool.java 60.97% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #305      +/-   ##
============================================
+ Coverage     46.38%   47.23%   +0.85%     
- Complexity     1677     1703      +26     
============================================
  Files           303      304       +1     
  Lines         12109    12225     +116     
  Branches       1208     1220      +12     
============================================
+ Hits           5617     5775     +158     
+ Misses         6054     5997      -57     
- Partials        438      453      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex268 alex268 merged commit f86645f into master Aug 20, 2024
7 checks passed
@alex268 alex268 deleted the query_table_client branch August 20, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants