Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for using keyword #397

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

polRk
Copy link

@polRk polRk commented Aug 14, 2024

Pull request type

Please check one the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What does it do?

Adds disposable support

Why is it needed?

Closes #353

How to test it?

{
   await using driver = new Driver()
}
// driver destroyed

Related issue(s)/PR(s)

#353

@polRk polRk changed the title [WIP]: feat: add support for using keyword feat: add support for using keyword Aug 14, 2024
@Zork33
Copy link
Collaborator

Zork33 commented Aug 21, 2024

Hi! I have attempted to do some basic test - https://github.com/ydb-platform/ydb-nodejs-sdk/blob/feat/add-support-using/src/__tests__/e2e/using-keyword.test.ts and received the following error:

TypeError: Symbol.asyncDispose is not defined.|

Seems that something is still missing to start using 'using'

@polRk
Copy link
Author

polRk commented Sep 10, 2024

TypeError: Symbol.asyncDispose is not defined.

Hi! Please, provide information about your runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support of using keyword for driver and session management
2 participants