[KQP] CBO hints warnings added (#9701)

ydb-platform · Sep 24, 2024 · ca658e7 · ca658e7
1 parent e079e2b
commit ca658e7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/ydb/core/kqp/opt/logical/kqp_opt_log.cpp b/ydb/core/kqp/opt/logical/kqp_opt_log.cpp
@@ -91,9 +91,9 @@ class TKqpLogicalOptTransformer : public TOptimizeTransformerBase {
 public:
     TStatus DoTransform(TExprNode::TPtr input, TExprNode::TPtr& output, TExprContext& ctx) override {
         auto status = TOptimizeTransformerBase::DoTransform(input, output, ctx);
-
-        for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedHintStrings()) {
-            YQL_CLOG(WARN, ProviderYdb) << "Unapplied hint: " + hint;
+        
+        for (const auto& hint: KqpCtx.GetOptimizerHints().GetUnappliedString()) {
+            ctx.AddWarning(YqlIssue({}, TIssuesIds::YQL_UNUSED_HINT, "Unapplied hint: " + hint));
         }
 
         return status;

diff --git a/ydb/library/yql/core/cbo/cbo_optimizer_new.cpp b/ydb/library/yql/core/cbo/cbo_optimizer_new.cpp
@@ -303,7 +303,7 @@ const TBaseProviderContext& TBaseProviderContext::Instance() {
     return staticContext;
 }
 
-TVector<TString> TOptimizerHints::GetUnappliedHintStrings() {
+TVector<TString> TOptimizerHints::GetUnappliedString() {
     TVector<TString> res;
 
     for (const auto& hint: JoinAlgoHints->Hints) {

diff --git a/ydb/library/yql/core/cbo/cbo_optimizer_new.h b/ydb/library/yql/core/cbo/cbo_optimizer_new.h
@@ -177,7 +177,7 @@ struct TOptimizerHints {
     std::shared_ptr<TJoinAlgoHints> JoinAlgoHints = std::make_shared<TJoinAlgoHints>();
     std::shared_ptr<TJoinOrderHints> JoinOrderHints = std::make_shared<TJoinOrderHints>();
 
-    TVector<TString> GetUnappliedHintStrings();
+    TVector<TString> GetUnappliedString();
 
     /* 
      *   The function accepts string with three type of expressions: array of (JoinAlgo | Card | JoinOrder):