Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pq writer and few renames #1757

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

niksaveliev
Copy link
Collaborator

@niksaveliev niksaveliev commented Feb 9, 2024

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Feb 9, 2024

2024-02-09 08:18:48 UTC Pre-commit check for e6e26f5 has started.
2024-02-09 08:18:50 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 08:20:49 UTC Build successful.
2024-02-09 08:21:05 UTC Tests are running...
🔴 2024-02-09 09:37:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67409 56483 0 1 10892 33

Copy link

github-actions bot commented Feb 9, 2024

2024-02-09 08:19:00 UTC Pre-commit check for e6e26f5 has started.
2024-02-09 08:19:02 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 08:20:57 UTC Build successful.
2024-02-09 08:21:10 UTC Tests are running...
🔴 2024-02-09 09:58:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14729 14531 0 13 135 50

}
PendingReserve.erase(it);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это ключевое место. Убрал метод write, перенес проверки сюда, и перетащил сюда удаление из PendingReserve

@niksaveliev niksaveliev marked this pull request as ready for review February 9, 2024 10:14
@niksaveliev niksaveliev merged commit db527f7 into ydb-platform:main Feb 9, 2024
5 of 7 checks passed
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
@vitstn vitstn mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants