Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy table with sequences and backup without NextVal #2285

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Copy table with sequences and backup without NextVal #2285

merged 11 commits into from
Mar 7, 2024

Conversation

shnikd
Copy link
Collaborator

@shnikd shnikd commented Feb 27, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 15:27:49 UTC Pre-commit check for 0908291 has started.
⚪ 2024-02-27 15:27:50 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-27 15:29:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 15:30:34 UTC Pre-commit check for 0908291 has started.
⚪ 2024-02-27 15:30:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-27 15:32:17 UTC Build successful.
⚪ 2024-02-27 15:32:26 UTC Tests are running...
🔴 2024-02-27 16:36:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14869 14739 0 26 84 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

⚪ 2024-02-27 15:52:44 UTC Pre-commit check for 0908291 has started.
⚪ 2024-02-27 15:52:47 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-27 15:54:40 UTC Build successful.
⚪ 2024-02-27 15:54:54 UTC Tests are running...
🔴 2024-02-27 16:59:12 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67969 57061 0 4 10883 21

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 10:54:16 UTC Pre-commit check for 26826f2 has started.
⚪ 2024-02-29 10:54:19 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-29 10:59:30 UTC Build successful.
⚪ 2024-02-29 10:59:41 UTC Tests are running...
🔴 2024-02-29 12:32:47 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14888 14747 0 24 92 25

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 10:54:17 UTC Pre-commit check for 26826f2 has started.
⚪ 2024-02-29 10:54:19 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-02-29 11:02:13 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

⚪ 2024-02-29 10:54:18 UTC Pre-commit check for 26826f2 has started.
⚪ 2024-02-29 10:54:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-29 10:59:06 UTC Build successful.
⚪ 2024-02-29 10:59:21 UTC Tests are running...
🔴 2024-02-29 12:32:02 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68024 57108 0 5 10890 21

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 12:41:51 UTC Pre-commit check for 7ee1f0b has started.
⚪ 2024-03-01 12:41:54 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-01 13:14:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 12:41:57 UTC Pre-commit check for 7ee1f0b has started.
⚪ 2024-03-01 12:42:00 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-01 13:21:19 UTC Build successful.
⚪ 2024-03-01 13:21:32 UTC Tests are running...
🔴 2024-03-01 15:11:33 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14885 14720 0 40 97 28

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

⚪ 2024-03-01 12:42:08 UTC Pre-commit check for 7ee1f0b has started.
⚪ 2024-03-01 12:42:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-01 13:19:11 UTC Build successful.
⚪ 2024-03-01 13:19:24 UTC Tests are running...
🔴 2024-03-01 15:06:07 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68068 57111 0 37 10894 26

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 09:45:05 UTC Pre-commit check for 03a7af1 has started.
⚪ 2024-03-04 09:45:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 10:03:29 UTC Build successful.
⚪ 2024-03-04 10:03:38 UTC Tests are running...
🔴 2024-03-04 11:08:53 UTC Test run completed, no test results found for commit 5a8e755. Please check build logs.
⚫ 2024-03-04 11:08:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 09:45:09 UTC Pre-commit check for 03a7af1 has started.
⚪ 2024-03-04 09:45:10 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 10:05:09 UTC Build successful.
⚪ 2024-03-04 10:05:44 UTC Tests are running...
🔴 2024-03-04 11:08:54 UTC Test run completed, no test results found for commit 5a8e755. Please check build logs.
⚫ 2024-03-04 11:08:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 09:45:38 UTC Pre-commit check for 03a7af1 has started.
⚪ 2024-03-04 09:45:41 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 10:10:27 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 11:10:14 UTC Pre-commit check for a88d0ef has started.
⚪ 2024-03-04 11:10:16 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 11:15:31 UTC Build successful.
⚪ 2024-03-04 11:15:41 UTC Tests are running...
🔴 2024-03-04 12:48:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68082 57147 0 12 10900 23
⚫ 2024-03-04 12:48:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 11:15:37 UTC Pre-commit check for a88d0ef has started.
⚪ 2024-03-04 11:15:39 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 11:21:23 UTC Build successful.
⚪ 2024-03-04 11:21:33 UTC Tests are running...
🔴 2024-03-04 12:48:46 UTC Test run completed, no test results found for commit ac8db1c. Please check build logs.
⚫ 2024-03-04 12:48:49 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 11:17:10 UTC Pre-commit check for a88d0ef has started.
⚪ 2024-03-04 11:17:11 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 11:21:36 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 12:57:17 UTC Pre-commit check for 01b656f has started.
⚪ 2024-03-04 12:57:18 UTC Build linux-x86_64-release-cmake14 is running...
🔴 2024-03-04 13:02:00 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 13:01:15 UTC Pre-commit check for 01b656f has started.
⚪ 2024-03-04 13:01:17 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 13:05:51 UTC Build successful.
⚪ 2024-03-04 13:06:01 UTC Tests are running...
🔴 2024-03-04 14:44:48 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67951 57003 0 19 10908 21

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 13:01:45 UTC Pre-commit check for 01b656f has started.
⚪ 2024-03-04 13:01:47 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 13:07:08 UTC Build successful.
⚪ 2024-03-04 13:07:17 UTC Tests are running...
🔴 2024-03-04 14:51:11 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14859 14691 0 30 111 27

@shnikd shnikd linked an issue Mar 4, 2024 that may be closed by this pull request
support backup of the sequences #1965
Closed
@shnikd shnikd changed the title Copy table with sequence Copy table with sequences Mar 4, 2024
@shnikd shnikd linked an issue Mar 4, 2024 that may be closed by this pull request
Support copy table with sequences #2425
Closed
@shnikd shnikd changed the title Copy table with sequences Copy table with sequences and backup without NextVal Mar 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 10:09:43 UTC Pre-commit check for e344fad has started.
⚪ 2024-03-05 10:09:45 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-05 10:22:32 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚪ 2024-03-05 10:09:51 UTC Pre-commit check for e344fad has started.
⚪ 2024-03-05 10:09:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-05 10:15:12 UTC Build successful.
⚪ 2024-03-05 10:15:24 UTC Tests are running...
🔴 2024-03-05 11:58:39 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14920 14763 0 23 88 46

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

⚪ 2024-03-07 00:10:18 UTC Pre-commit check for 4d10b8b has started.
⚪ 2024-03-07 00:10:20 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-07 00:15:04 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

⚪ 2024-03-07 00:13:35 UTC Pre-commit check for 4d10b8b has started.
⚪ 2024-03-07 00:13:36 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-07 00:19:13 UTC Build successful.
⚪ 2024-03-07 00:19:26 UTC Tests are running...
🔴 2024-03-07 01:57:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14951 14775 0 35 113 28

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024 •
edited
Loading

⚪ 2024-03-07 00:16:36 UTC Pre-commit check for 4d10b8b has started.
⚪ 2024-03-07 00:16:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-07 00:22:05 UTC Build successful.
⚪ 2024-03-07 00:22:18 UTC Tests are running...
🔴 2024-03-07 01:42:23 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68249 57302 0 5 10919 23

@shnikd shnikd requested a review from snaury March 7, 2024 11:07
@shnikd shnikd merged commit 26c7891 into ydb-platform:main Mar 7, 2024
3 of 5 checks passed
CyberROFL
CyberROFL reviewed Mar 11, 2024
View reviewed changes
ydb/core/tx/schemeshard/schemeshard_import_flow_proposals.cpp
return nullptr;
}

for(const auto& column: item.Scheme.columns()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это нужно унести в core/ydb_convert.

ydb/core/tx/schemeshard/schemeshard_path.cpp
for (const auto& child: Path.Base()->GetChildren()) {
auto name = child.first;

TPath childPath = Path.Child(name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const.

ydb/core/tx/schemeshard/schemeshard_import__create.cpp
@@ -850,7 +850,10 @@ struct TSchemeShard::TImport::TTxProgress: public TSchemeShard::TXxport::TTxBase
}

if (item.State == EState::CreateTable) {
item.DstPathId = Self->MakeLocalId(TLocalPathId(record.GetPathId()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не очень понял, почему понадобилось это изменение?

This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
shnikd added a commit to shnikd/ydb that referenced this pull request May 30, 2024
@shnikd
Copy table with sequences and backup without NextVal (ydb-platform#2285)
2b4191b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL left review comments

@snaury snaury snaury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support copy table with sequences support backup of the sequences
3 participants
@shnikd @snaury @CyberROFL