Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-2957 fix error in s3 stream read actor #2702

Merged
merged 2 commits into from
Mar 13, 2024
Merged

YQ-2957 fix error in s3 stream read actor #2702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c2fbbe
Fixed error during poison handling
GrigoriyPA Mar 13, 2024
9e73e3f
Removed exception handling
GrigoriyPA Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ydb/library/yql/providers/s3/actors/yql_s3_read_actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2158,17 +2158,13 @@ class TS3ReadCoroImpl : public TActorCoroImpl {
LOG_CORO_D("RunCoroBlockArrowParserOverFile - FINISHED");
}

STRICT_STFUNC_EXC(StateFunc,
STRICT_STFUNC(StateFunc,
hFunc(TEvPrivate::TEvReadStarted, Handle);
hFunc(TEvPrivate::TEvDataPart, Handle);
hFunc(TEvPrivate::TEvReadFinished, Handle);
hFunc(TEvPrivate::TEvContinue, Handle);
hFunc(TEvPrivate::TEvReadResult2, Handle);
hFunc(NActors::TEvents::TEvPoison, Handle);
, catch (const std::exception& e) {
TIssues issues{TIssue{TStringBuilder() << "An unknown exception has occurred: '" << e.what() << "'"}};
Send(ComputeActorId, new IDqComputeActorAsyncInput::TEvAsyncInputError(InputIndex, issues, NYql::NDqProto::StatusIds::INTERNAL_ERROR));
}
)

void ProcessOneEvent() {
Expand Down
1 change: 1 addition & 0 deletions ydb/tests/tools/kqprun/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ sync_dir
example
udfs
*.log
*.json
*.sql
*.bin
3 changes: 3 additions & 0 deletions ydb/tests/tools/kqprun/kqprun.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ void RunScript(const TExecutionOptions& executionOptions, const NKqpRun::TRunner
if (!runner.ExecuteScript(executionOptions.ScriptQuery, executionOptions.ScriptQueryAction, executionOptions.ScriptTraceId)) {
ythrow yexception() << "Script execution failed";
}
Cout << colors.Yellow() << "Fetching script results..." << colors.Default() << Endl;
if (!runner.FetchScriptResults()) {
ythrow yexception() << "Fetch script results failed";
}
Expand All @@ -61,6 +62,8 @@ void RunScript(const TExecutionOptions& executionOptions, const NKqpRun::TRunner
if (executionOptions.HasResults()) {
runner.PrintScriptResults();
}

Cout << colors.Yellow() << "Finalization of kqp runner..." << colors.Default() << Endl;
}


Expand Down
Loading