Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check alter version only for ss applyIf #3823

Merged
merged 2 commits into from
May 24, 2024
Merged

Check alter version only for ss applyIf #3823

merged 2 commits into from
May 24, 2024

Conversation

niksaveliev
Copy link
Collaborator

@niksaveliev niksaveliev commented Apr 17, 2024 •
edited
Loading

No description provided.

@niksaveliev niksaveliev marked this pull request as ready for review April 17, 2024 13:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:13:55 UTC Pre-commit check for 3b7958e has started.
⚪ 2024-04-17 13:13:58 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-04-17 13:48:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:14:50 UTC Pre-commit check for 3b7958e has started.
⚪ 2024-04-17 13:14:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-04-17 13:55:19 UTC Build successful.
⚪ 2024-04-17 13:57:02 UTC Tests are running...
🔴 2024-04-17 15:29:18 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10196 9951 0 39 176 30

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

⚪ 2024-04-17 13:30:26 UTC Pre-commit check for 3b7958e has started.
⚪ 2024-04-17 13:30:29 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-04-17 14:06:56 UTC Build successful.
⚪ 2024-04-17 14:08:44 UTC Tests are running...
🔴 2024-04-17 15:33:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
34277 30863 0 13 3379 22

ijon
ijon requested changes Apr 26, 2024
View reviewed changes
ydb/core/protos/flat_scheme_op.proto Outdated
@@ -1482,6 +1482,7 @@ message TApplyIf {
optional uint64 PathId = 1;
optional uint64 PathVersion = 2;
optional uint64 LockedTxId = 3;
optional bool CheckGeneralVersion = 4 [default = true];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы инвертировал флаг: CheckTypeSpecificVersion или CheckEntityVersion c default-значением false.
В понимании, что есть схемная сущность со своей версией (entity-version), а есть path, через которую эта сущность становится видима. Path и entity связаны, но не совпадают. У пути своя path-version, включающая entity-version. В общем случае работа с сущностями идёт в терминах путей, проверять надо path-version. И в базовой логике не должно быть никаких сомнений.

Для этого кажется лучше, чтобы флага "проверь общую (или path-version)" не было -- лучше иметь флаг "а сейчас не так как всегда, проверь специфику".

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 06:38:18 UTC Pre-commit check for 732d750 has started.
⚪ 2024-05-24 06:41:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-24 07:20:03 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 06:38:22 UTC Pre-commit check for 732d750 has started.
⚪ 2024-05-24 06:41:11 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-24 07:21:40 UTC Build successful.
⚪ 2024-05-24 07:21:54 UTC Tests are running...
🔴 2024-05-24 09:30:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10844 10754 0 42 35 13

@github-actions GitHub Actions
Copy link

github-actions bot commented May 24, 2024 •
edited
Loading

⚪ 2024-05-24 06:38:24 UTC Pre-commit check for 732d750 has started.
⚪ 2024-05-24 06:41:19 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-24 07:22:54 UTC Build successful.
⚪ 2024-05-24 07:23:06 UTC Tests are running...
🔴 2024-05-24 09:05:29 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38311 33510 0 3 4788 10

@niksaveliev niksaveliev merged commit d1fcb9c into ydb-platform:main May 24, 2024
8 of 12 checks passed
This was referenced May 27, 2024
Closed
Closed
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@niksaveliev @MrLolthe1st
Check alter version only for ss applyIf (ydb-platform#3823)
0de8177
@niksaveliev niksaveliev mentioned this pull request May 29, 2024
Merged
This was referenced May 29, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request May 30, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request May 31, 2024
Merged
This was referenced Jun 6, 2024
Closed
Closed
Merged
Merged
@serbel324 serbel324 mentioned this pull request Jun 7, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 11, 2024
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 19, 2024
Merged
Merged
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niksaveliev @ijon