Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3184 support create table as select in kqprun #4412

Merged
merged 5 commits into from
May 13, 2024
Merged

YQ-3184 support create table as select in kqprun #4412

merged 5 commits into from
May 13, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented May 8, 2024 •
edited
Loading

Changelog entry

Improved kqprun for test create table as select

Changelog category

  • Improvement

Additional information

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 18:29:17 UTC Pre-commit check for 392174d has started.
⚪ 2024-05-08 18:29:20 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-08 18:31:23 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 18:29:17 UTC Pre-commit check for 392174d has started.
⚪ 2024-05-08 18:29:20 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-08 18:31:29 UTC Build successful.
⚪ 2024-05-08 18:32:59 UTC Tests are running...
🟢 2024-05-08 18:46:03 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 154 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 18:29:26 UTC Pre-commit check for 392174d has started.
⚪ 2024-05-08 18:29:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-08 18:31:35 UTC Build successful.
⚪ 2024-05-08 18:33:02 UTC Tests are running...
🟢 2024-05-08 18:45:08 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3059 1260 0 0 1799 0

@GrigoriyPA GrigoriyPA requested a review from uzhastik May 8, 2024 18:37
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 20:00:19 UTC Pre-commit check for 440c064 has started.
⚪ 2024-05-08 20:00:22 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-08 20:02:27 UTC Build successful.
⚪ 2024-05-08 20:03:55 UTC Tests are running...
🟢 2024-05-08 20:16:40 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 154 0 0 0 0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 20:00:20 UTC Pre-commit check for 440c064 has started.
⚪ 2024-05-08 20:00:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-08 20:02:26 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024 •
edited
Loading

⚪ 2024-05-08 20:01:21 UTC Pre-commit check for 440c064 has started.
⚪ 2024-05-08 20:01:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-08 20:03:25 UTC Build successful.
⚪ 2024-05-08 20:04:48 UTC Tests are running...
🟢 2024-05-08 20:16:28 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3061 1262 0 0 1799 0

@GrigoriyPA GrigoriyPA requested a review from uzhastik May 8, 2024 20:03
uzhastik
uzhastik reviewed May 9, 2024
View reviewed changes
ydb/tests/tools/kqprun/src/ydb_setup.cpp Outdated
@@ -388,7 +388,9 @@ TRequestResult TYdbSetup::GetScriptExecutionOperationRequest(const TString& oper
meta.ExecutionStatus = static_cast<NYdb::NQuery::EExecStatus>(deserializedMeta.exec_status());
meta.ResultSetsCount = deserializedMeta.result_sets_meta_size();
meta.Ast = deserializedMeta.exec_stats().query_ast();
meta.Plan = deserializedMeta.exec_stats().query_plan();
if (deserializedMeta.exec_stats().query_plan()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В чем ценность этого if? Что плохого в старом коде?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Операция GetScriptExecutionOperationRequest вызывается много раз и при финализации не успешного запроса план может потеряться тут (стать равным "{}"):

ydb/ydb/core/kqp/proxy_service/kqp_script_executions.cpp

Line 2548 in 2ef009d

.JsonDocument(Request.QueryPlan.value_or("{}"))

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Благодаря этому if, можно получить план запроса, который зафейлился на этапе исполнения

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if исправил, теперь сравнивается с "{}"

@GrigoriyPA GrigoriyPA force-pushed the YQ-3184-support-create-table-as-select-for-s3 branch from 96412bc to 9518642 Compare May 13, 2024 10:10
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

⚪ 2024-05-13 10:12:09 UTC Pre-commit check for d4c5d39 has started.
⚪ 2024-05-13 10:12:10 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-13 10:14:14 UTC Build successful.
⚪ 2024-05-13 10:15:36 UTC Tests are running...
🟢 2024-05-13 10:27:02 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3061 1262 0 0 1799 0

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

⚪ 2024-05-13 10:13:54 UTC Pre-commit check for d4c5d39 has started.
⚪ 2024-05-13 10:13:57 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-13 10:15:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited
Loading

⚪ 2024-05-13 10:14:12 UTC Pre-commit check for d4c5d39 has started.
⚪ 2024-05-13 10:14:15 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-13 10:16:20 UTC Build successful.
⚪ 2024-05-13 10:17:42 UTC Tests are running...
🟢 2024-05-13 10:30:26 UTC Tests successful.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 154 0 0 0 0

@GrigoriyPA GrigoriyPA requested a review from uzhastik May 13, 2024 10:19
@GrigoriyPA GrigoriyPA merged commit 3c85e58 into ydb-platform:main May 13, 2024
5 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3184-support-create-table-as-select-for-s3 branch May 13, 2024 11:13
@GrigoriyPA GrigoriyPA mentioned this pull request May 16, 2024
Closed
This was referenced May 16, 2024
Merged
Merged
@serbel324 serbel324 mentioned this pull request May 24, 2024
Merged
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request May 28, 2024
@GrigoriyPA @MrLolthe1st
YQ-3184 support create table as select in kqprun (ydb-platform#4412)
a802367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
improvement new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @uzhastik