Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tenantinfo handler added DatabaseStorage #7554

Merged
merged 2 commits into from
Aug 12, 2024
Merged

tenantinfo handler added DatabaseStorage #7554

merged 2 commits into from
Aug 12, 2024

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Aug 8, 2024 •
edited
Loading

Changelog entry

issue
-- changed StorageUsage to TablesStorage. If there is no quota info about specifi storage type - it doesn't return
-- added DatabaseStorage
-- use SoftQuota for storage limit

expected reply

"TablesStorage": [
     {
        "Type": "SSD",
        "Size": "12345", 
        "Limit": "12345", 
        "SoftQuota": "12345", 
        "HardQuota": "12345",
    },
    {
        "Type": "HDD",
        "Size": "12345", 
        "Limit": "12345", 
        "SoftQuota": "12345", 
        "HardQuota": "12345",
    }
],
"DatabaseStorage": [
     {
        "Type": "SSD",
        "Size": "12345", 
        "Limit": "12345"
    },
    {
        "Type": "HDD",
        "Size": "12345", 
        "Limit": "12345"
    }
]

Changelog category

  • Improvement

Additional information

...

@StekPerepolnen StekPerepolnen requested a review from a team as a code owner August 8, 2024 08:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 08:52:26 UTC Pre-commit check for cbf3fcf has started.
⚪ 2024-08-08 08:56:07 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 10:52:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39737 34410 0 2 5310 15

⚪ 2024-08-08 10:58:02 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 11:07:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21 (only retried tests) 12 0 0 0 9

🟢 2024-08-08 11:10:17 UTC Build successful.
🟡 2024-08-08 11:10:47 UTC ydbd size 8.1 GiB changed* by +119.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ff0fd33 merge: cbf3fcf diff diff %
ydbd size 8 675 902 120 Bytes 8 676 024 840 Bytes +119.8 KiB +0.001%
ydbd stripped size 472 174 152 Bytes 472 178 088 Bytes +3.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 08:53:38 UTC Pre-commit check for cbf3fcf has started.
⚪ 2024-08-08 08:56:28 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 09:04:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 08:54:05 UTC Pre-commit check for cbf3fcf has started.
⚪ 2024-08-08 08:57:44 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 11:04:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10975 10920 0 15 24 16

🟢 2024-08-08 11:05:29 UTC Build successful.
🟢 2024-08-08 11:05:58 UTC ydbd size 5.4 GiB changed* by +79.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9dbab08 merge: cbf3fcf diff diff %
ydbd size 5 834 397 384 Bytes 5 834 479 056 Bytes +79.8 KiB +0.001%
ydbd stripped size 1 465 529 456 Bytes 1 465 545 392 Bytes +15.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen force-pushed the json-tenantinfo-quotas3 branch 3 times, most recently from b662581 to d6d84ba Compare August 8, 2024 13:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:56:38 UTC Pre-commit check for fdefac6 has started.
⚪ 2024-08-08 13:59:15 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-08 14:31:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:56:54 UTC Pre-commit check for fdefac6 has started.
⚪ 2024-08-08 14:00:19 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 14:06:19 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 13:59:26 UTC Pre-commit check for fdefac6 has started.
⚪ 2024-08-08 14:02:05 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-08 14:30:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 14:34:29 UTC Pre-commit check for d17ba81 has started.
⚪ 2024-08-08 14:37:18 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 14:43:41 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 14:36:18 UTC Pre-commit check for d17ba81 has started.
⚪ 2024-08-08 14:39:03 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-08 16:13:51 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 16:15:35 UTC Pre-commit check for 514b2d6 has started.
⚪ 2024-08-08 16:19:22 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 18:20:39 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10985 10938 0 7 24 16

🟢 2024-08-08 18:21:54 UTC Build successful.
🟢 2024-08-08 18:22:21 UTC ydbd size 5.4 GiB changed* by +82.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78d1439 merge: 514b2d6 diff diff %
ydbd size 5 839 792 744 Bytes 5 839 877 336 Bytes +82.6 KiB +0.001%
ydbd stripped size 1 467 330 960 Bytes 1 467 350 672 Bytes +19.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 16:17:07 UTC Pre-commit check for 514b2d6 has started.
⚪ 2024-08-08 16:21:05 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 18:11:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39742 34413 0 4 5310 15

⚪ 2024-08-08 18:15:54 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 18:24:58 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26 (only retried tests) 14 0 0 3 9

🟢 2024-08-08 18:25:05 UTC Build successful.
🟡 2024-08-08 18:25:43 UTC ydbd size 8.1 GiB changed* by +140.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 78d1439 merge: 514b2d6 diff diff %
ydbd size 8 682 534 824 Bytes 8 682 678 608 Bytes +140.4 KiB +0.002%
ydbd stripped size 472 557 672 Bytes 472 561 576 Bytes +3.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

⚪ 2024-08-08 16:17:13 UTC Pre-commit check for 514b2d6 has started.
⚪ 2024-08-08 16:19:56 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 16:25:47 UTC Build successful.

@StekPerepolnen StekPerepolnen changed the title json tenantinfo quotas3 tenantinfo handler added DatabaseStorage Aug 8, 2024
adameat
adameat requested changes Aug 12, 2024
View reviewed changes
ydb/core/viewer/viewer_tenantinfo.h Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:06:06 UTC Pre-commit check for 868fc28 has started.
⚪ 2024-08-12 09:09:09 UTC Check linux-x86_64-release-clang14 is running...
⚫ 2024-08-12 09:11:46 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:06:09 UTC Pre-commit check for 868fc28 has started.
⚪ 2024-08-12 09:09:07 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-12 09:11:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:06:26 UTC Pre-commit check for 868fc28 has started.
⚪ 2024-08-12 09:09:12 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-12 09:11:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:13:15 UTC Pre-commit check for 9741bb6 has started.
⚪ 2024-08-12 09:15:59 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-12 09:22:03 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:15:43 UTC Pre-commit check for 9741bb6 has started.
⚪ 2024-08-12 09:18:36 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-12 11:35:40 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10999 10942 0 11 27 19

🟢 2024-08-12 11:36:54 UTC Build successful.
🟢 2024-08-12 11:37:24 UTC ydbd size 5.4 GiB changed* by +83.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4efd471 merge: 9741bb6 diff diff %
ydbd size 5 846 875 272 Bytes 5 846 961 080 Bytes +83.8 KiB +0.001%
ydbd stripped size 1 468 605 136 Bytes 1 468 622 608 Bytes +17.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 12, 2024 •
edited
Loading

⚪ 2024-08-12 09:15:47 UTC Pre-commit check for 9741bb6 has started.
⚪ 2024-08-12 09:18:36 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-12 11:21:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39781 34453 0 3 5311 14

⚪ 2024-08-12 11:25:31 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-12 11:34:26 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 11 0 0 0 9

🟢 2024-08-12 11:34:34 UTC Build successful.
🟡 2024-08-12 11:35:14 UTC ydbd size 8.1 GiB changed* by +146.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 4efd471 merge: 9741bb6 diff diff %
ydbd size 8 694 175 112 Bytes 8 694 325 000 Bytes +146.4 KiB +0.002%
ydbd stripped size 472 897 736 Bytes 472 902 024 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen merged commit 9095bb1 into ydb-platform:main Aug 12, 2024
10 of 12 checks passed
@StekPerepolnen StekPerepolnen deleted the json-tenantinfo-quotas3 branch August 12, 2024 13:18
@GrigoriyPA GrigoriyPA mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adameat adameat adameat approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StekPerepolnen @adameat