Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEMBERNAME has been renamed to MEMBER_NAME #9666

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

MEMBERNAME has been renamed to MEMBER_NAME #9666

wants to merge 3 commits into from
+40 −40

Conversation

dorooleg
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@dorooleg dorooleg requested a review from a team as a code owner September 24, 2024 00:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 00:17:03 UTC Pre-commit check linux-x86_64-release-clang14 for 286dcfc has started.
⚪ 2024-09-24 00:17:13 UTC Artifacts will be uploaded here
⚪ 2024-09-24 00:20:04 UTC ya make is running...
🔴 2024-09-24 00:24:19 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 00:17:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 286dcfc has started.
⚪ 2024-09-24 00:17:13 UTC Artifacts will be uploaded here
⚪ 2024-09-24 00:20:13 UTC ya make is running...
🔴 2024-09-24 00:24:59 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 00:17:28 UTC Pre-commit check linux-x86_64-release-asan for 286dcfc has started.
⚪ 2024-09-24 00:17:38 UTC Artifacts will be uploaded here
⚪ 2024-09-24 00:20:31 UTC ya make is running...
🔴 2024-09-24 00:24:40 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 06:28:05 UTC Pre-commit check linux-x86_64-release-clang14 for f263584 has started.
⚪ 2024-09-24 06:28:31 UTC Artifacts will be uploaded here
⚪ 2024-09-24 06:31:22 UTC ya make is running...
🟢 2024-09-24 06:37:32 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 06:28:07 UTC Pre-commit check linux-x86_64-release-asan for f263584 has started.
⚪ 2024-09-24 06:28:18 UTC Artifacts will be uploaded here
⚪ 2024-09-24 06:31:15 UTC ya make is running...
🔴 2024-09-24 08:19:12 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11800 11596 0 49 38 117

🟢 2024-09-24 08:20:20 UTC Build successful.
🟡 2024-09-24 08:21:20 UTC ydbd size 5.7 GiB changed* by +126.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1002b94 merge: f263584 diff diff %
ydbd size 6 079 048 480 Bytes 6 079 178 296 Bytes +126.8 KiB +0.002%
ydbd stripped size 1 519 895 600 Bytes 1 519 930 064 Bytes +33.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 06:29:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for f263584 has started.
⚪ 2024-09-24 06:29:20 UTC Artifacts will be uploaded here
⚪ 2024-09-24 06:32:25 UTC ya make is running...
🟡 2024-09-24 07:48:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41172 35591 0 10 5470 101

⚪ 2024-09-24 07:52:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 08:04:36 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 26 0 0 0 94

🟡 2024-09-24 08:05:31 UTC ydbd size 8.4 GiB changed* by +260.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1002b94 merge: f263584 diff diff %
ydbd size 9 070 923 400 Bytes 9 071 190 208 Bytes +260.6 KiB +0.003%
ydbd stripped size 490 539 784 Bytes 490 550 600 Bytes +10.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA reviewed Sep 24, 2024
View reviewed changes
ydb/core/kqp/proxy_service/kqp_proxy_service_impl.h Outdated
@@ -425,7 +425,7 @@ class TResourcePoolsCache {
const i64 Rank;

TClassifierInfo(const NResourcePool::TClassifierSettings& classifierSettings)
: Membername(classifierSettings.Membername)
: Membername(classifierSettings.MemberName)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может быть ещё поле Membername в TClassifierInfo стоит переименовать (чтобы за одно везде исправить)?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 17:15:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 006631d has started.
⚪ 2024-09-24 17:16:00 UTC Artifacts will be uploaded here
⚪ 2024-09-24 17:18:49 UTC ya make is running...
🟡 2024-09-24 18:43:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41172 35604 0 4 5458 106

⚪ 2024-09-24 18:47:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-24 18:58:13 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 21 0 0 1 91

🟢 2024-09-24 18:58:20 UTC Build successful.
🟢 2024-09-24 18:58:57 UTC ydbd size 8.5 GiB changed* by +36.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2b5f88d merge: 006631d diff diff %
ydbd size 9 073 512 024 Bytes 9 073 549 512 Bytes +36.6 KiB +0.000%
ydbd stripped size 490 601 672 Bytes 490 604 488 Bytes +2.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 17:16:22 UTC Pre-commit check linux-x86_64-release-asan for 006631d has started.
⚪ 2024-09-24 17:16:32 UTC Artifacts will be uploaded here
⚪ 2024-09-24 17:19:24 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited
Loading

⚪ 2024-09-24 17:16:59 UTC Pre-commit check linux-x86_64-release-clang14 for 006631d has started.
⚪ 2024-09-24 17:17:02 UTC Artifacts will be uploaded here
⚪ 2024-09-24 17:20:00 UTC ya make is running...
🟢 2024-09-24 18:05:19 UTC Build successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrigoriyPA GrigoriyPA GrigoriyPA approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorooleg @GrigoriyPA